Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package json main field extension order #3664

Merged
merged 2 commits into from Jul 18, 2023
Merged

package json main field extension order #3664

merged 2 commits into from Jul 18, 2023

Conversation

dylan-conway
Copy link
Collaborator

fixes #3659

@github-actions
Copy link

@dylan-conway 1 files with test failures on linux-x64:

  • test/js/web/fetch/fetch-leak.test.js

View test output

#d32f63ce1be0a32733417c1293b6b0eee97f8362

@github-actions
Copy link

@dylan-conway 1 files with test failures on linux-x64-baseline:

  • test/js/web/fetch/fetch-leak.test.js

View test output

#d32f63ce1be0a32733417c1293b6b0eee97f8362

@github-actions
Copy link

@dylan-conway 5 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/fetch/fetch_headers.test.js

View test output

#d32f63ce1be0a32733417c1293b6b0eee97f8362

@github-actions
Copy link

@dylan-conway 6 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#d32f63ce1be0a32733417c1293b6b0eee97f8362

@Jarred-Sumner Jarred-Sumner merged commit 9273e29 into main Jul 18, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-3659 branch July 18, 2023 02:26
@capaj
Copy link
Contributor

capaj commented Jul 18, 2023

lovely, this should fix it for good. I've been using this exact resolution order in vitest without any issue at least a year now on multiple projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants