Pass constructor arguments to TextDecoder

[Parzival-3141]

The constructor now actually sets TextDecoder properties using the options parameter. This lets users enable the fatal parameter, closing #3572.

[Jarred-Sumner]

Thank you. This is close, but not ready to merge yet

[Parzival-3141]

Two things that I noticed while testing:

1. TextDecoder.decode throws a generic Error instead of TypeError as specified in the WHATWG standard. Is this intentional or an oversight?
2. The getter for TextDecoder.ignoreBOM seems to be broken and will always return undefined. I'm not sure why this happens

[paperdave]

point 1 is definitely an oversight, or maybe there wasnt a binding for throwTypeError at the time.

the hint for point 2 is in encoding.classes.ts

[Parzival-3141]

@paperdave hm, I can't seem to get my changes in encoding.classes.ts to work. Running make codegen fails as well:

~/bun$ make codegen
bun src/bun.js/scripts/generate-jssink.js
/usr/bin/clang-format-15 -i  src/bun.js/bindings/JSSink.cpp  src/bun.js/bindings/JSSink.h
/home/ubuntu/bun/src/bun.js/WebKit/Source/JavaScriptCore/create_hash_table src/bun.js/bindings/JSSink.cpp > src/bun.js/bindings/JSSinkLookupTable.h
/usr/bin/bash: line 1: /home/ubuntu/bun/src/bun.js/WebKit/Source/JavaScriptCore/create_hash_table: No such file or directory
make: *** [Makefile:1474: generate-sink] Error 127

[paperdave]

We should copy that script into our repo, but you can use make generate-classes instead

[Parzival-3141]

@paperdave no dice unfortunately. make generate-classes runs fine but ignoreBOM is still undefined. Is there something else I'm missing?

[Jarred-Sumner]

Thank you