Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4089 #4105

Merged
merged 3 commits into from Aug 21, 2023
Merged

Fixes #4089 #4105

merged 3 commits into from Aug 21, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Fixes #4089

How did you verify your code works?

Automated tests

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

@Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/worker.test.ts

View test output

#80b024023b31b9e5b76f6d8ece35c7c88a950e4f

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

@Jarred-Sumner 2 files with test failures on linux-x64-baseline:

  • test/js/bun/test/test-test.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#80b024023b31b9e5b76f6d8ece35c7c88a950e4f

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/js/bun/test/test-test.test.ts

View test output

#80b024023b31b9e5b76f6d8ece35c7c88a950e4f

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

@Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#80b024023b31b9e5b76f6d8ece35c7c88a950e4f

Copy link
Collaborator

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after isStrictEqual change

@Jarred-Sumner Jarred-Sumner merged commit 752e59f into main Aug 21, 2023
14 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/deep-equals-url branch August 21, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deepEquals returns true for different URLs.
2 participants