Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IncomingRequest.req to be overwritten. #4154

Merged
merged 4 commits into from Aug 17, 2023

Conversation

paperdave
Copy link
Collaborator

What does this PR do?

Closes #4141

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • Added new test
  • Verified manually server.js works

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

@paperdave 1 files with test failures on linux-x64:

  • test/js/bun/test/test-test.test.ts

View test output

#19e6f1156af1b1059e84f3d1c13675030cebcc13

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

@paperdave 2 files with test failures on linux-x64-baseline:

  • test/js/bun/test/test-test.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#19e6f1156af1b1059e84f3d1c13675030cebcc13

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

@paperdave 4 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/watch/fs.watch.test.ts

View test output

#19e6f1156af1b1059e84f3d1c13675030cebcc13

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

@paperdave 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/bun-isMainThread.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#19e6f1156af1b1059e84f3d1c13675030cebcc13

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the test

@Jarred-Sumner Jarred-Sumner merged commit f74585f into main Aug 17, 2023
11 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/req-req-not-readonly branch August 17, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support server.js
2 participants