New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.toString('hex') gets 40x faster #4237

Merged

Jarred-Sumner merged 1 commit into main from jarred/simd-hex

Aug 21, 2023

Collaborator

Jarred-Sumner commented Aug 21, 2023

What does this PR do?

How did you verify your code works?

There are existing tests, which failed many times before they started passing locally


          40x faster .toString('hex')

3ebb64b

github-actions bot commented Aug 21, 2023

❌ @Jarred-Sumner 1 files with test failures on linux-x64-baseline:

test/js/web/fetch/fetch.test.ts

View test output

^{#69a8e3a0f2fecf128807d3ea314334c785ba9117}

github-actions bot commented Aug 21, 2023

❌ @Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/bun/util/filesink.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/web/worker.test.ts

View test output

^{#69a8e3a0f2fecf128807d3ea314334c785ba9117}

github-actions bot commented Aug 21, 2023

❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:

test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/node/fs/fs.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#69a8e3a0f2fecf128807d3ea314334c785ba9117}

Jarred-Sumner merged commit def5a85 into main

16 of 20 checks passed

Jarred-Sumner deleted the jarred/simd-hex branch

August 21, 2023 15:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment