Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto.EC constructor #4242

Merged
merged 2 commits into from Aug 21, 2023
Merged

Fix crypto.EC constructor #4242

merged 2 commits into from Aug 21, 2023

Conversation

paperdave
Copy link
Collaborator

What does this PR do?

This might not actually fix the bug but regardless we should do this.

I could not reproduce the original issue exactly.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

@paperdave 2 files with test failures on linux-x64-baseline:

  • test/bundler/esbuild/splitting.test.ts
  • test/js/third_party/fsevents/fsevents.test.ts

View test output

#215e93c2ef6a4d65839b041b73af9da27f186cfe

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

@paperdave 1 files with test failures on linux-x64:

  • test/js/third_party/fsevents/fsevents.test.ts

View test output

#215e93c2ef6a4d65839b041b73af9da27f186cfe

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

@paperdave 7 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/fsevents/fsevents.test.ts
  • test/js/web/worker.test.ts

View test output

#215e93c2ef6a4d65839b041b73af9da27f186cfe

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

@paperdave 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#215e93c2ef6a4d65839b041b73af9da27f186cfe

@paperdave paperdave merged commit cdace9b into main Aug 21, 2023
11 checks passed
@paperdave paperdave deleted the fix-ec-constructor branch August 21, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants