feat: Windows + CMake Build System #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 1 files with test failures on linux-x64:
|
|
❌ @paperdave 1 files with test failures on linux-x64-baseline:
|
|
❌ @paperdave 9 files with test failures on bun-darwin-x64-baseline:
|
Jarred-Sumner
force-pushed
the
jarred/prepare-for-libuv
branch
from
a3b9307
to
3775081
Compare
|
✅ |
|
❌ @paperdave 6 files with test failures on bun-darwin-aarch64:
|
Works around a Windows issue
|
✅ #838c85c821f89aa0b99a6ec62997e78cea1367e1 |
Jarred-Sumner
commented
Oct 27, 2023
| @@ -2032,7 +2037,7 @@ pub const DNSResolver = struct { | |||
| .code = bun.String.static(err.code()), | |||
| .message = bun.String.static(err.label()), | |||
| }; | |||
|
|
|||
| defer ip_slice.deinit(); | |||
There was a problem hiding this comment.
TODO: this is sus
…o jarred/prepare-for-libuv
Jarred-Sumner
commented
Oct 27, 2023
| @@ -145,7 +145,7 @@ pub const Arguments = struct { | |||
| var paths = [_]string{ cwd, filename }; | |||
| const outpath = try std.fs.path.resolve(allocator, &paths); | |||
| defer allocator.free(outpath); | |||
| var file = try std.fs.openFileAbsolute(outpath, std.fs.File.OpenFlags{ .mode = .read_only }); | |||
| var file = try bun.openFileZ(&try std.os.toPosixPath(outpath), std.fs.File.OpenFlags{ .mode = .read_only }); | |||
There was a problem hiding this comment.
TODO: this shouldn't be posix
Jarred-Sumner
commented
Oct 27, 2023
| supported_method = .copyfile; | ||
| supported_method_to_use = .copyfile; | ||
| }, | ||
| // error.ENXIO => { |
Jarred-Sumner
commented
Oct 27, 2023
| const NetworkChannel = sync.Channel(*NetworkTask, .{ .Static = 8192 }); | ||
|
|
||
| // Windows seems to stack overflow in debug builds due to the size of these allocations. | ||
| const TaskChannel = sync.Channel(Task, .{ .Static = 4096 / (if (Environment.isWindows) 16 else 1) }); |
There was a problem hiding this comment.
todo: remove this diff
Jarred-Sumner
commented
Oct 27, 2023
src/install/install.zig
Outdated
| } | ||
|
|
||
| pub fn sleep(this: *PackageManager) void { | ||
| if (this.wait_count.swap(0, .Monotonic) > 0) return; | ||
| Output.flush(); | ||
| _ = this.waiter.wait() catch 0; | ||
| bun.Mimalloc.mi_collect(false); |
There was a problem hiding this comment.
collect is bad
RaisinTen
added a commit
to RaisinTen/bun
that referenced
this pull request
Oct 27, 2023
It was added in oven-sh#4410. The `src` directory is not supposed to be a part of the path. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added a commit
to RaisinTen/bun
that referenced
this pull request
Oct 27, 2023
Running the script ended with this error: ```sh $ bash ./scripts/setup.sh ... ninja: error: loading 'build.ninja': No such file or directory ``` It happens because the `build.ninja` file is inside the `build` directory, not the current directory, so `ninja` is not able to detect the presence of that file and run the builds. The error started happening in oven-sh#4410, where this script was introduced. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
don't have time before bun 1.0 to learn enough to get good at windows I/O
so we will use libuv on Windows
this is the prep code, does nothing but hopefully it's mergeable and then we can implement
FilePoll,PollRefand then various functions.How did you verify your code works?
it doesn't work