Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid inserting extraneous"accept-encoding" header #5057

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

iidebyo
Copy link
Contributor

@iidebyo iidebyo commented Sep 12, 2023

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes
  1. add test to confirm no "accept-encoding" header has been added
  2. add check to avoid writing the header

How did you verify your code works?

  • I included a test for the new code, or an existing test covers it

@iidebyo
Copy link
Contributor Author

iidebyo commented Sep 12, 2023

see #5043

@Jarred-Sumner Jarred-Sumner merged commit 9101774 into oven-sh:main Sep 13, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
* add no extraneous accept-encoding header test

* ensure fetch honors no decompress opt

* fix format on test/js/node/http/node-http.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants