Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BunFile.slice) fix slice when length is greater than the size #5186

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

cirospaciari
Copy link
Collaborator

What does this PR do?

Fix: #5080

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

✅ test failures on linux-x64-baseline have been resolved.

#b9047d204ecca156c9f051ba1f33a5e54b5f4df5

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@cirospaciari 1 files with test failures on linux-x64:

  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#b9047d204ecca156c9f051ba1f33a5e54b5f4df5

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@cirospaciari 5 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/default.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/stream/direct-readable-stream.test.tsx
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#b9047d204ecca156c9f051ba1f33a5e54b5f4df5

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@cirospaciari 6 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#b9047d204ecca156c9f051ba1f33a5e54b5f4df5

@cirospaciari cirospaciari marked this pull request as draft September 13, 2023 02:21
@cirospaciari cirospaciari marked this pull request as ready for review September 13, 2023 03:06
@Jarred-Sumner Jarred-Sumner merged commit d37602f into main Sep 14, 2023
16 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-file-slice branch September 14, 2023 02:49
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
…en-sh#5186)

* check the limits for file, when slicing

* check eof

* undo test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BunFile.slice() hangs if end is greater than length of file
2 participants