Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dup and close file descriptors #5341

Merged
merged 11 commits into from
Sep 15, 2023
Merged

dup and close file descriptors #5341

merged 11 commits into from
Sep 15, 2023

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Sep 14, 2023

What does this PR do?

fixes #5435

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@Jarred-Sumner
Copy link
Collaborator

are you sure we always call the unregister function before close?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@dylan-conway 1 files with test failures on linux-x64:

  • test/bundler/esbuild/splitting.test.ts

View test output

#600685b587320534f9254e8179f1c2512041fcdf

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@dylan-conway 1 files with test failures on linux-x64-baseline:

  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#600685b587320534f9254e8179f1c2512041fcdf

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@dylan-conway 5 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/stream/direct-readable-stream.test.tsx
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/worker.test.ts

View test output

#600685b587320534f9254e8179f1c2512041fcdf

@github-actions
Copy link
Contributor

@dylan-conway 8 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setInterval.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#600685b587320534f9254e8179f1c2512041fcdf

@dylan-conway dylan-conway changed the title keep track of file descriptors registered with epoll dup and close file descriptors Sep 15, 2023
@Jarred-Sumner Jarred-Sumner merged commit d26adde into main Sep 15, 2023
14 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/track-epoll-fds branch September 15, 2023 08:39
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
* track one shot fds

* dup fd

* skip for rearm on mac

* dup if fd

* cleanup

* force unregister on close

* deinitForceUnregister

* test

* add prompts

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw mode issue on WSL
2 participants