Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP listen behavior being non-compliant with node #5689

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

paperdave
Copy link
Collaborator

Work from SuperAuguste on #4658, I messed up rebasing that branch and couldn't push a fix.

What does this PR do?

Closes #4651

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I ran make js and committed the transpiled changes
  • I or my editor ran Prettier on the changed files (or I ran bun fmt)
  • I included a test for the new code, or an existing test covers it

@Jarred-Sumner Jarred-Sumner merged commit f77df12 into main Sep 18, 2023
14 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave+aug/fix-invalid-listen branch September 18, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastify "Is port ... in use?"
3 participants