feat(KeyObject) #5940
feat(KeyObject) #5940
Conversation
|
I may just not be reading the code right but it's important that createPublicKey and createPrivateKey also handle the |
cirospaciari
force-pushed
the
ciro/key-object
branch
from
04f94f9
to
b512791
Compare
|
✅ |
|
❌ @cirospaciari 9 files with test failures on bun-darwin-aarch64:
|
cirospaciari
force-pushed
the
ciro/key-object
branch
from
3f86fbb
to
bbc6b17
Compare
|
❌ @cirospaciari 4 files with test failures on linux-x64-baseline:
|
|
❌ @cirospaciari 5 files with test failures on linux-x64:
|
|
❌ @cirospaciari 6 files with test failures on bun-darwin-x64-baseline:
|
| key.indexOf("PRIVATE KEY-----") !== -1 && (key = _createPublicKey(key).export()); | ||
| } | ||
| return key; | ||
| } | ||
| function getArrayBufferOrView(buffer, name, encoding) { |
There was a problem hiding this comment.
we should move this one to native code in a future PR
src/js/node/crypto.js
Outdated
| if (key instanceof KeyObject) { | ||
| key = key.export(); | ||
| } else if (key instanceof CryptoKey) { | ||
| key = KeyObject.from(key).export(); |
There was a problem hiding this comment.
maybe we should make export a static method that does this as one function instead of two
but we can do that in a future PR
There was a problem hiding this comment.
Fixed on 59ebd2d
src/js/node/crypto.js
Outdated
| return hash.update(this._opad).update(h).digest(); | ||
| }; | ||
| module.exports = function (alg, key) { | ||
| if (key instanceof KeyObject) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed on 59ebd2d
| } | ||
| }; | ||
|
|
||
| function _generateKeyPairSync(algorithm, options) { |
There was a problem hiding this comment.
why didn't we do these functions in native code?
There was a problem hiding this comment.
Actually, I am not sure either, I will change that to move most of it to native and only use KeyObject.from when needed.
|
|
||
| switch (type) { | ||
|
|
||
| case DataViewType: |
There was a problem hiding this comment.
at some point we should add a macro for this
Float16Array will be a thing in like a year probably
What does this PR do?
Add KeyObject and related methods
Fix #2036
Fix #1454
Fix #5036
Fix #4983
Fix #4692
Fix #2730
Maybe Related with #3950 #4596 #5122
How did you verify your code works?
I wrote automated tests