Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env_loader): Ignore spaces before equals sign #602

Merged
merged 2 commits into from
Jul 12, 2022
Merged

fix(env_loader): Ignore spaces before equals sign #602

merged 2 commits into from
Jul 12, 2022

Conversation

FinnRG
Copy link
Collaborator

@FinnRG FinnRG commented Jul 11, 2022

Closes #519. Before this PR, .env files like PORT =8080 wouldn't get parsed.

@FinnRG FinnRG added the bug Something isn't working label Jul 11, 2022
Jarred-Sumner
Jarred-Sumner reviewed Jul 12, 2022
View reviewed changes
src/env_loader.zig Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit a6ab6e2 into oven-sh:main Jul 12, 2022
@Jarred-Sumner
Copy link
Collaborator

Thank you

@FinnRG FinnRG deleted the fix/519 branch July 12, 2022 08:43
@renovate renovate bot mentioned this pull request Jul 15, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to access env values
2 participants
@FinnRG @Jarred-Sumner