Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebCryptoAPI: remove JWK "EdDSA" alg checks #6294

Merged
merged 1 commit into from
Oct 5, 2023
Merged

WebCryptoAPI: remove JWK "EdDSA" alg checks #6294

merged 1 commit into from
Oct 5, 2023

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 4, 2023

What does this PR do?

This removes the check in SubtleCrypto importKey() for JWK Ed25519 "alg" member values. These have been removed in WICG/webcrypto-secure-curves#24

The other portion (JWK Ed25519 "alg" member export) was not even implemented as far as i can see.

@panva
Copy link
Contributor Author

panva commented Oct 4, 2023

cc @ThatOneBro @Jarred-Sumner

@cirospaciari
Copy link
Collaborator

LGTM

@cirospaciari cirospaciari self-requested a review October 5, 2023 23:26
@cirospaciari cirospaciari merged commit 30b8993 into oven-sh:main Oct 5, 2023
14 of 19 checks passed
@panva panva deleted the crypto-update-eddsa-alg branch October 6, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants