feat(install): automatically migrate package-lock.json to bun.lockb #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re lockfile edge cases :/
paperdave
commented
Oct 10, 2023
src/install/install.zig
Outdated
| var root = Lockfile.Package{}; | ||
| var needs_new_lockfile = load_lockfile_result != .ok or (load_lockfile_result.ok.buffers.dependencies.items.len == 0 and manager.package_json_updates.len > 0); | ||
| var needs_new_lockfile = load_lockfile_result != .ok or load_lockfile_result.ok.buffers.dependencies.items.len == 0 and manager.package_json_updates.len > 0; |
There was a problem hiding this comment.
probably not. lol
paperdave
commented
Oct 10, 2023
| /// | ||
| /// By default, the underlying buffer is filled with "invalid_id" to indicate this package ID | ||
| /// was not resolved | ||
| resolutions: PackageIDSlice = .{}, |
There was a problem hiding this comment.
lets not move the order of these fields
There was a problem hiding this comment.
damn i didnt realize i did that
paperdave
commented
Oct 10, 2023
|
can u add a test case for |
|
cool |
|
✅ |
|
❌ @paperdave 9 files with test failures on bun-darwin-aarch64:
|
|
❌ @paperdave 6 files with test failures on linux-x64:
|
|
❌ @paperdave 6 files with test failures on linux-x64-baseline:
|
|
❌ @paperdave 9 files with test failures on bun-darwin-x64-baseline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If you do not have a
bun.lockb, but apackage-lock.jsonexists, this PR reads that data and generates a bun lockfile in memory, and uses that for the install.I think the migration can be made faster, but people will ideally only run this once per project, so it is fine.
If a
yarn.lockorpnpm-lock.yamlexists, a warning is printedAll of the above only happens if no
bun.lockbis present. so this has no perf impact on existing projects.You can also run
bun pm migrateto run just the migrator code path, useful for testing.There are some situations where this migration is not 100% accurate to what npm installs, which is due to bugs and limitations/optimizations of Bun's package hoisting logic.