Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix ws/pubsub; closed ws don't publish to topic #6739

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[docs] fix ws/pubsub; closed ws don't publish to topic #6739

merged 2 commits into from
Oct 30, 2023

Conversation

RohitKaushal7
Copy link
Contributor

What does this PR do?

fix #6691 - fix docs in close callback of a websocket connection. replaced ws.publish with server.publish

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

@Jarred-Sumner Jarred-Sumner merged commit 08fdbb3 into oven-sh:main Oct 30, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

websocket not publishing to topic after connection close.
2 participants
@RohitKaushal7 @Jarred-Sumner