Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minify-whitespace case undefined #6808

Merged
merged 1 commit into from Oct 30, 2023
Merged

Conversation

krk
Copy link
Contributor

@krk krk commented Oct 30, 2023

Print a space before undefined in printUndefined.

fix #6750

What does this PR do?

Fix minify-whitespace formatting error.

How did you verify your code works?

I wrote automated tests

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I or my editor ran zig fmt on the changed files
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

Print a space before `undefined` in `printUndefined`.

fix oven-sh#6750
@dylan-conway dylan-conway merged commit 68146d0 into oven-sh:main Oct 30, 2023
15 of 21 checks passed
@dylan-conway
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

case undefined with minify whitespace causes a syntax error
2 participants