workflows(bun-mac-x64.yml): Fix typo "bun-obj-darwin-x6" #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? <!-- **Please explain what your changes do**, example: --> Change 'bun-obj-darwin-x6' to 'bun-obj-darwin-x64' at line 110 in bun-mac-x64.yml <!-- This adds a new flag --bail to bun test. When set, it will stop running tests after the first failure. This is useful for CI environments where you want to fail fast. --> - [x] Documentation or TypeScript types (it's okay to leave the rest blank in this case) - [ ] Code changes ### How did you verify your code works? <!-- **For code changes, please include automated tests**. Feel free to uncomment the line below --> <!-- I wrote automated tests --> <!-- If JavaScript/TypeScript modules or builtins changed: - [ ] I ran `make js` and committed the transpiled changes - [ ] I or my editor ran Prettier on the changed files (or I ran `bun fmt`) - [ ] I included a test for the new code, or an existing test covers it --> <!-- If Zig files changed: - [ ] I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be - [ ] I or my editor ran `zig fmt` on the changed files - [ ] I included a test for the new code, or an existing test covers it - [ ] JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed --> <!-- If new methods, getters, or setters were added to a publicly exposed class: - [ ] I added TypeScript types for the new methods, getters, or setters --> <!-- If dependencies in tests changed: - [ ] I made sure that specific versions of dependencies are used instead of ranged or tagged versions --> <!-- If functions were added to exports.zig or bindings.zig - [ ] I ran `make headers` to regenerate the C header file --> <!-- If \*.classes.ts files were added or changed: - [ ] I ran `make codegen` to regenerate the C++ and Zig code --> <!-- If a new builtin ESM/CJS module was added: - [ ] I updated Aliases in `module_loader.zig` to include the new module - [ ] I added a test that imports the module - [ ] I added a test that require() the module -->
|
interesting that we dont actually use that variable. still, cant believe i left that typo. maybe we should just remove the unused variables. |
Electroid
approved these changes
Oct 31, 2023
antongolub
pushed a commit
to antongolub-forks/bun
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change
bun-obj-darwin-x6tobun-obj-darwin-x64at line 110 in bun-mac-x64.yml.How did you verify your code works?