Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak napi PR #7177

Merged
merged 7 commits into from
Nov 18, 2023
Merged

Tweak napi PR #7177

merged 7 commits into from
Nov 18, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Tweaks to #7175, plus another napi change

How did you verify your code works?

Locally, but tested with Prisma, resvg, and next build

Copy link
Contributor

github-actions bot commented Nov 17, 2023

@Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/web/fetch/body-stream.test.ts

View test output

#4829970c27797ac90ddd48bb277eb3f743c5f46b

Copy link
Contributor

github-actions bot commented Nov 17, 2023

@Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/cli/install/registry/bun-install-registry.test.ts

View test output

#4829970c27797ac90ddd48bb277eb3f743c5f46b

Copy link
Contributor

github-actions bot commented Nov 17, 2023

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/cli/install/registry/bun-install-registry.test.ts

View test output

#4829970c27797ac90ddd48bb277eb3f743c5f46b

Copy link
Contributor

@Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#4829970c27797ac90ddd48bb277eb3f743c5f46b

@Jarred-Sumner Jarred-Sumner merged commit 6c200c0 into main Nov 18, 2023
19 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/napi-follow-up branch November 18, 2023 01:00
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* Fix assertion failure

* Fix the test

* Fix assertion failure

* Update bun.lockb

* Add node-gyp

* Update CMakeLists.txt

* Update napi.test.ts

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant