Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose correct resolved package for peer dependencies #7192

Merged

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

fixes a test in bun-install-registry.test.ts

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@dylan-conway dylan-conway merged commit f5bf67b into main Nov 18, 2023
19 of 25 checks passed
@dylan-conway dylan-conway deleted the dylan/find-matching-peer-dep-before-choosing-resolved branch November 18, 2023 03:15
Copy link

@dylan-conway 3 files with test failures on bun-darwin-aarch64:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/which.test.ts

View test output

#c803a92ee214f68dc1f58b05af4768aaf94179b5

Copy link

@dylan-conway 8 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/registry/bun-install-registry.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#c803a92ee214f68dc1f58b05af4768aaf94179b5

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* fix sometimes failing install test

* loop to make sure it happens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant