Cleanup how build errors are displayed slightly

[Jarred-Sumner]

What does this PR do?

Two things:

Formatting tweaks

• Removes extra newlines
• Fixes logger.rangeOfIdentifier to include the complete length of the identifier (usage of defer broke that)
• Making the selected portion colored is too intense IMO for longer lines

Before:

After:

Build-time error for unsupported ESM<>CommonJS features

You can use require and import in the same file in Bun, but you cannot use import and module.exports in the same file. You also cannot use exports, module, with or top-level return.

Currently, we rely on JavaScriptCore's errors for these things, but they're really hard to read and don't give us an easy way to show a stack trace pointing to which line exactly caused it.

This moves those errors to build-time.

Input:

import "abc";

with (Bun) {
  write("/tmp/file.txt", escapeHTML(file("/tmp/file.html").text()));
  console.log({
    contents: file("/tmp/file.txt").text(),
  });
}

Before (note how it says "import call"):

After:

Input:

import _ from "lodash";
module.exports = _.constant(42);

Before:

After:

How did you verify your code works?

I wrote a few tests

[github-actions]

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-aarch64:

• test/integration/next/default-pages-dir/test/dev-server.test.ts
• test/js/bun/test/test-test.test.ts
• test/js/bun/util/which.test.ts
• test/js/web/worker.test.ts

View test output

^{#c5fde7b556fbfd57ed76fd39e264bc6b23c09b6b}

[github-actions]

✅ test failures on linux-x64-baseline have been resolved.

^{#c5fde7b556fbfd57ed76fd39e264bc6b23c09b6b}

[github-actions]

❌ @Jarred-Sumner 1 files with test failures on linux-x64:

• test/integration/next/default-pages-dir/test/next-build.test.ts

View test output

^{#c5fde7b556fbfd57ed76fd39e264bc6b23c09b6b}

[github-actions]

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64:

• test/integration/next/default-pages-dir/test/next-build.test.ts
• test/js/bun/spawn/spawn-streaming-stdout.test.ts
• test/js/bun/util/filesink.test.ts
• test/js/bun/util/which.test.ts
• test/js/node/fs/fs.test.ts
• test/js/third_party/webpack/webpack.test.ts
• test/js/web/timers/setInterval.test.js
• test/js/web/timers/setTimeout.test.js

View test output

^{#c5fde7b556fbfd57ed76fd39e264bc6b23c09b6b}

[github-actions]

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

• test/integration/next/default-pages-dir/test/dev-server.test.ts
• test/js/bun/spawn/spawn-streaming-stdout.test.ts
• test/js/bun/util/filesink.test.ts
• test/js/bun/util/which.test.ts
• test/js/node/fs/fs.test.ts
• test/js/node/watch/fs.watchFile.test.ts
• test/js/third_party/webpack/webpack.test.ts
• test/js/web/timers/setTimeout.test.js

View test output

^{#c5fde7b556fbfd57ed76fd39e264bc6b23c09b6b}

[dylan-conway]

do we also need a color reset here?

[dylan-conway]

oh, I don't think we do because it would've reset on line 341