Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts/download-zig.sh #7364

Merged
merged 2 commits into from Nov 29, 2023
Merged

Conversation

joeyw
Copy link
Contributor

@joeyw joeyw commented Nov 29, 2023

What does this PR do?

Ubuntu 22.04 x86_64 fresh install and bun build attempt using latest contributing guide.

bun setup was failing with:

image

Resulting from scripts/download-zig.sh

$ scripts/download-zig.sh

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

After removing the gzip flag, the following error then resulted

$ uname -i 
x86_64
$ scripts/download-zig.sh
$ .cache/zig/zig
bash: .cache/zig/zig: cannot execute binary file: Exec format error

How did you verify your code works?

$ rm -rf .cache
$ scripts/download-zig.sh
$ .cache/zig/zig version
0.12.0-dev.1604+caae40c21

bun setup
image

@Jarred-Sumner Jarred-Sumner merged commit 9888527 into oven-sh:main Nov 29, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

@joeyw joeyw deleted the fix-download-zig-script branch November 30, 2023 00:43
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* fix: scripts/download-zig.sh file is not gzipped

* fix: scripts/download-zig.sh Linux x86_64 arch var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants