Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocket) improve WebSocket Client #7371

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Nov 29, 2023

What does this PR do?

Closes #6686

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added autobahn in web/websocket/autobahn.test.ts

Copy link

github-actions bot commented Nov 29, 2023

@cirospaciari 4 files with test failures on bun-darwin-aarch64:

  • test/cli/run/require-cache.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/web/fetch/body-stream.test.ts

View test output

#f2120d885d1a53e1cd1c0c11043f65ef4636e17d

Copy link

github-actions bot commented Nov 29, 2023

@cirospaciari 1 files with test failures on linux-x64:

  • test/js/third_party/postgres/postgres.test.ts

View test output

#f2120d885d1a53e1cd1c0c11043f65ef4636e17d

Copy link

github-actions bot commented Nov 29, 2023

✅ test failures on linux-x64-baseline have been resolved.

#f2120d885d1a53e1cd1c0c11043f65ef4636e17d

Copy link

github-actions bot commented Nov 29, 2023

@cirospaciari 7 files with test failures on bun-darwin-x64-baseline:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#36afae1ce34dcb81fcf0d7cd29cb2453f2274d05

@cirospaciari cirospaciari force-pushed the ciro/ws-client-improvements branch 2 times, most recently from 3acceb6 to 542defe Compare November 30, 2023 02:57
@cirospaciari cirospaciari marked this pull request as ready for review November 30, 2023 02:57
Copy link

github-actions bot commented Nov 30, 2023

@cirospaciari 8 files with test failures on bun-darwin-x64:

  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#f2120d885d1a53e1cd1c0c11043f65ef4636e17d

@Jarred-Sumner Jarred-Sumner merged commit 906ba8b into main Dec 1, 2023
18 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/ws-client-improvements branch December 1, 2023 02:00
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* improvements

* autobahn tests

* add all tests

* check if docker is active move autobahn to a new file

* fix non SIMD UTF8 validation

* use no trim to catch utf8 issues

* fix extended payload fragmentation

* fmt

* Update src/string_immutable.zig

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket client reliability
2 participants