Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement import.meta.{dirname, filename} for Node.js compatibility #8127

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Implement import.meta.{dirname, filename} for Node.js compatibility #8127

merged 1 commit into from
Jan 12, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Implement import.meta.dirname and import.meta.filename

How did you verify your code works?

There is a test

@Jarred-Sumner Jarred-Sumner merged commit 0783b4b into main Jan 12, 2024
19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/import-meta-dirnamefilenamepath branch January 12, 2024 22:26
This was referenced Jan 12, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#31810885cd96347fced38b695dab013f1c0ffa74

@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_compile.test.ts
  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#31810885cd96347fced38b695dab013f1c0ffa74

@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 3 files with test failures on linux-x64:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#31810885cd96347fced38b695dab013f1c0ffa74

@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64-baseline:

  • test/cli/test/bun-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#31810885cd96347fced38b695dab013f1c0ffa74

@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64:

  • test/cli/test/bun-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#31810885cd96347fced38b695dab013f1c0ffa74

@risu729 risu729 mentioned this pull request Jan 13, 2024
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Jan 13, 2024
Merged
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
@Jarred-Sumner @ryoppippi
Implement import.meta.{dirname, filename} for Node.js compatibility (…
26ae281 
…oven-sh#8127)

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Jarred-Sumner