Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve bun pm trust output #9371

Merged
merged 13 commits into from
Mar 13, 2024
Merged

improve bun pm trust output #9371

merged 13 commits into from
Mar 13, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Mar 12, 2024

What does this PR do?

This change splits bun pm trust(ed) into three subcommands:

  • bun pm trust: expects either package names or --all to trust all dependencies. Will run their scripts and add to package.json
  • bun pm untrusted: display dependencies with blocked lifecycle scripts
  • bun pm default-trusted: print the default trusted dependencies list

also includes a fix for bin linking bug, fixes #8759

examples:

Screenshot 2024-03-11 at 6 15 51 PM
Screenshot 2024-03-11 at 6 16 15 PM
Screenshot 2024-03-11 at 6 16 37 PM
Screenshot 2024-03-11 at 6 20 10 PM
Screenshot 2024-03-11 at 6 20 20 PM
Screenshot 2024-03-11 at 6 20 36 PM
Screenshot 2024-03-11 at 6 26 07 PM

How did you verify your code works?

existing tests

Copy link
Contributor

github-actions bot commented Mar 12, 2024

❌🪟 @dylan-conway, there are 14 test regressions on Windows x86_64

  • test\cli\install\migration\migrate.test.ts
  • test\cli\run\env.test.ts
  • test\cli\run\run-process-env.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\bun\sqlite\sqlite.test.js
  • test\js\node\dns\node-dns.test.js
  • test\js\third_party\esbuild\esbuild-child_process.test.ts
  • test\js\web\fetch\body-stream.test.ts
  • test\js\web\timers\performance.test.js
  • test\js\web\websocket\websocket.test.js
  • test\js\web\workers\worker.test.ts
  • test\js\web\timers\setTimeout.test.js

Full Test Output

@sequencerr
Copy link
Contributor

closes: #9363

@dylan-conway dylan-conway marked this pull request as ready for review March 12, 2024 19:57
@dylan-conway dylan-conway merged commit e45ece0 into main Mar 13, 2024
26 of 31 checks passed
@dylan-conway dylan-conway deleted the dylan/trusted-improvements branch March 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PathAlreadyExists on unrelated package on bun install -g
3 participants