Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bunx tests to pass on Windows #9729

Merged
merged 54 commits into from Apr 4, 2024
Merged

Get bunx tests to pass on Windows #9729

merged 54 commits into from Apr 4, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • Fixes "unable to find executable" error caused by checking the last write time of <bunx-dir>/node_modules/uglifyjs/package.json rather than <bunx-dir>/package.json
  • should fix SharingViolation error
  • Should fix flakiness from deleting tmp dirs, I think

How did you verify your code works?

Tests

Copy link

github-actions bot commented Mar 30, 2024

Copy link

github-actions bot commented Mar 30, 2024

Copy link

github-actions bot commented Mar 30, 2024

Copy link

github-actions bot commented Mar 31, 2024

.FILE_TOO_LARGE => .@"2BIG",
.SHARING_VIOLATION => if (comptime Environment.isDebug) brk: {
bun.Output.debugWarn("Received SHARING_VIOLATION, indicates file handle should've been opened with FILE_SHARE_DELETE", .{});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see this was found.

src/bun.zig Show resolved Hide resolved
@jdalton
Copy link
Contributor

jdalton commented Apr 1, 2024

There's is a lot changed here. Hard to reason about all of it (means I defer to unit tests and CI happiness), but would also welcome any context/note comments.

@Jarred-Sumner Jarred-Sumner merged commit 00f27fb into main Apr 4, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/bunx branch April 4, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants