New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get bunx tests to pass on Windows #9729
Conversation
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64: |
❌ @Jarred-Sumner 2 files with test failures on linux-x64-baseline: |
❌ @Jarred-Sumner 10 files with test failures on bun-windows-x86_64-haswell
|
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-x64:
|
.FILE_TOO_LARGE => .@"2BIG", | ||
.SHARING_VIOLATION => if (comptime Environment.isDebug) brk: { | ||
bun.Output.debugWarn("Received SHARING_VIOLATION, indicates file handle should've been opened with FILE_SHARE_DELETE", .{}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad to see this was found.
There's is a lot changed here. Hard to reason about all of it (means I defer to unit tests and CI happiness), but would also welcome any context/note comments. |
What does this PR do?
<bunx-dir>/node_modules/uglifyjs/package.json
rather than<bunx-dir>/package.json
SharingViolation
errorHow did you verify your code works?
Tests