-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version selectors 1.x
/1.0.x
result in 400/404
response errors on install
#37
Comments
# Why This seems to be an issue introduced on Bun's backend, see oven-sh/setup-bun#37 for more info. # How - Workaround broken `1.x` selectors by using `latest` # Test Plan See CI passing # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
1.x
/1.0.x
causes 400 bad request on install1.x
/1.0.x
result in 400 bad responses on install
1.x
/1.0.x
result in 400 bad responses on install1.x
/1.0.x
result in 400
response errors on install
If this shouldn't have worked from the start, consider adding it 😄 The benefit of |
This is an issue with bun's api, sadly, I can't do anything with it. Electorid must solve it. |
I'd figure as much 😄 Thanks for pulling in the right person to solve it. |
We actually think this could be a bug in Bun. These errors are not from Github, we're investigating. |
Use of 'v1.x' breaks bun in CI. For now just use 'v1' oven-sh/setup-bun#37
# Why This seems to be an issue introduced on Bun's backend, see oven-sh/setup-bun#37 for more info. # How - Workaround broken `1.x` selectors by using `latest` # Test Plan See CI passing # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Looks like this is already fixed. |
It isn't. It's giving a different error now. When I try 1.x, I get this 404 error:
I guess we should re-open this issue. And maybe link it to an issue on bun side? |
I tried it and it works. Maybe you can try again? :D |
Something is wrong with bun's download api again. https://github.com/oven-sh/setup-bun/actions/runs/9020175817 |
1.x
/1.0.x
result in 400
response errors on install1.x
/1.0.x
result in 400/404
response errors on install
The issue seems triggered each time a bun new version is in the release pipeline: new version seems to be announced to the download system before the pipeline has finished and binaries are available. And fallback to previous matching latest version does not seem to work. |
We use bun in various parts of the expo/expo repository, e.g. here. Like the node setup action, we use a version selector with a
.x
, e.g.,node-version: 18.x
.This seemed to work until some days ago when our CI started failing with the following message:
A quick test showed that using the exact version number does seem to work, but
1.x
or1.0.x
won't anymore. Is this something that never should have worked, or a bug? 😄1.0.x
1.x
1.0.11
latest
See
1.0.11
responseSee
latest
responseThe text was updated successfully, but these errors were encountered: