Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of Subscription in MetadataParser #1141

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

marcinjagielnicki
Copy link
Contributor

@marcinjagielnicki marcinjagielnicki commented Oct 13, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets
License MIT

Before this change Root Type: Subscription wasn't correcly recognised during metadata parsing while using PHP Annotations/Attributes

@Vincz
Copy link
Collaborator

Vincz commented Nov 7, 2023

Hi @marcinjagielnicki !
Just a question to better understand your use case. How would you implement the realtime subscriptions?

@marcinjagielnicki
Copy link
Contributor Author

marcinjagielnicki commented Nov 7, 2023

Hey @Vincz,
I'm already working on a bundle that I can consider as working. It's using mercure protocole as a async communcation channel.
In next weeks my bundle will be ready to be published as public composer package :)

@Vincz
Copy link
Collaborator

Vincz commented Nov 8, 2023

@marcinjagielnicki Ho, really nice. Can't wait to see this! Could definitively use it on a bunch of my projects.
About your PR, is it everything you need to make your bundle work with this one?

@marcinjagielnicki
Copy link
Contributor Author

@Vincz at this moment yes, if I will need any other changes I will make separated PR

@Vincz Vincz merged commit 501193b into overblog:master Mar 5, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants