Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 / PHP 8.3 compatibility #1144

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Symfony 7 / PHP 8.3 compatibility #1144

merged 11 commits into from
Dec 11, 2023

Conversation

Vincz
Copy link
Collaborator

@Vincz Vincz commented Dec 1, 2023

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Tests pass? yes/no
Documented? yes/no
Fixed tickets #...
License MIT

@Vincz Vincz mentioned this pull request Dec 11, 2023
@Vincz Vincz self-assigned this Dec 11, 2023
@Vincz Vincz requested a review from mcg-web December 11, 2023 12:35
mcg-web
mcg-web previously approved these changes Dec 11, 2023
Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vincz ! Some cleanup and this can be merge !

tests/Functional/App/config/typeShorthand/config.yml Outdated Show resolved Hide resolved
tests/Functional/App/config/typeShorthand/config.yml Outdated Show resolved Hide resolved
tests/Functional/App/config/validator/config.yml Outdated Show resolved Hide resolved
tests/Functional/App/config/validator/config.yml Outdated Show resolved Hide resolved
@Vincz Vincz merged commit a223567 into overblog:master Dec 11, 2023
38 checks passed
@Vincz
Copy link
Collaborator Author

Vincz commented Dec 11, 2023

@mcg-web Thank boss! Fixed & merged :) Shall we publish a new version?

@jerowork
Copy link

jerowork commented Feb 5, 2024

@mcg-web Could you create a new release, including these changes? :) Thanks!

@victormacko
Copy link

Thanks so much @Vincz & @mcg-web for all your hard work in getting this working on Symfony 7 -- it's such a great package!!
Any ideas if you're planning a new release soon? Just waiting on this package before being able to make the upgrade. Thank you in advance :)

@luckyraul
Copy link

@Vincz graphiql also please

@victormacko
Copy link

Thanks so much @Vincz - can I check if v1 is still 'dev', or is that production-ready now? (the index page shows it as being still in dev :/ ... Thank you so much for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants