Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler & update phpcs #1155

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Fix profiler & update phpcs #1155

merged 4 commits into from
Feb 20, 2024

Conversation

Vincz
Copy link
Collaborator

@Vincz Vincz commented Jan 29, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #...
License MIT

This fix the problem with the profiler if the schema doesn't have a subscription.
It's related to #1112 and the fact that Webonyx expects null from not found type with the TypeResolver while we raise an exception.

@Vincz Vincz requested a review from mcg-web January 29, 2024 07:47
@Vincz
Copy link
Collaborator Author

Vincz commented Jan 29, 2024

@mcg-web Hey mate! It would be great if you could check this (just a bunch of fixes and CS). Also, we should release a new version as the latests commits are fixing a bunch of problematics issues (and the SF 7 compat).

@Vincz Vincz requested review from mcg-web and removed request for mcg-web February 1, 2024 15:22
Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Vincz Vincz merged commit a6f5792 into overblog:master Feb 20, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants