Allow for linked validations to be named differently to property #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joesaunderson! Good catch. Don't think is a BC either. Anyway, that was clearly not intended. |
Thanks @Vincz. Do you know if this issue is intended too? Happy to raise another PR to fix if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were overriding the
propertyvariable with thepropertyfrom thelink... this meant that the property (of an input or argument) had to match the property of the linked validation too.This fixes that, allowing them to be separate, meaning you can have a property named
fooand link it to a validation namedbar.Not sure if this is a breaking change... as technically the bug prevented people from having different properties -> entity properties, so there shouldn't be any skew anyway.