Do not use container in compiler passes #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
don't-boot-container-in-pass
branch
from
71411d5
to
1c7b8eb
Compare
By manually constructing the `TypeGenerator` in `TypeGeneratorPass` we gain performance benefits because we don't have the boot the whole container while we are in fact compiling the container. The container should not be used in compiler passes: > As a rule, only work with services definition in a compiler pass and do not create service instances. In practice, this means using the methods has(), findDefinition(), getDefinition(), setDefinition(), etc. instead of get(), set(), etc. Fixes 899
ruudk
force-pushed
the
don't-boot-container-in-pass
branch
from
1c7b8eb
to
40d34eb
Compare
mcg-web
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By manually constructing the
TypeGeneratorinTypeGeneratorPasswe gain performancebenefits because we don't have the boot the whole container while we are in fact compiling
the container.
The container should not be used in compiler passes:
Fixes 899