Support defining enum values by callable and/or generator #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an `ObjectType` uses a Generator to provide the `fields`, the decorator fails with: ``` Exception : You can only iterate a generator by-reference if it declared that it yields by-reference ``` Therefore, we convert the iterator to an array and modify it, and then return the array.
ruudk
force-pushed
the
generator-callable
branch
from
afceb2d
to
539bbbd
Compare
mcg-web
approved these changes
Dec 23, 2021
|
Thank you @ruudk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new feature merged in webonyx/graphql-php#1040.
It allows returning enum values by closure and/or generator.
While working on this I also noticed that the object decorator doesn't work properly when the objects fields are returned by a generator. That's now fixed as well.
I had to add a PHPStan ignore line because of this issue: webonyx/graphql-php#1041