Fix type generation for Composite symfony validator with explicit 'constraints' key #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @bravik for the fix ! Can you please add a test covering this case? |
|
@mcg-web There are only 3 tests for TypeGenerator at all.. Please, I just don't have enough mental strength to do this, while all this war is going on out here... |
|
Updated fix to take into account other options passed to validation constraint |
bravik
force-pushed
the
fix-composite-validation-constraints
branch
from
6033ad4
to
dfcb58f
Compare
bravik
force-pushed
the
fix-composite-validation-constraints
branch
from
dfcb58f
to
8c5c685
Compare
|
Ok I can understand ! I will add test later with your example in #991. Thanks again for the fix and the feedback ! |
mcg-web
approved these changes
Mar 4, 2022
|
@mcg-web will a patch version be released? |
|
released in 0.14.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #991