Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CS to Github Actions #52

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Move CS to Github Actions #52

merged 1 commit into from
Mar 14, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Mar 14, 2021

No description provided.

@simPod
Copy link
Contributor Author

simPod commented Mar 14, 2021

@mcg-web I've run this without 8a78a51 and expected some failure but the check gives no error. I don't use cs-fixer so maybe if you could confirm this works as expected?

@mcg-web
Copy link
Member

mcg-web commented Mar 14, 2021

Yes @simPod, this should failed since header is required by config.

@simPod
Copy link
Contributor Author

simPod commented Mar 14, 2021

@mcg-web travis does not fail as well. It fails locally. Not sure how that tool works TBH 🤷🏾

@mcg-web
Copy link
Member

mcg-web commented Mar 14, 2021

seem like I'm missing something, maybe the difference come from travis phpcs cache. Lets try with a next change, can you replace that by private static $instances = array(); please?

@simPod
Copy link
Contributor Author

simPod commented Mar 14, 2021

now GA failed so I guess it's overall working and we can keep only the first commit?

@mcg-web
Copy link
Member

mcg-web commented Mar 14, 2021

yes we can keep only the first commit, can you rewrite the history please, so we can merge this?

@simPod
Copy link
Contributor Author

simPod commented Mar 14, 2021

sure done

Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mcg-web mcg-web merged commit 8576920 into overblog:master Mar 14, 2021
@simPod simPod deleted the fixer-ga branch March 14, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants