Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PHP 8.2 on CI #66

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Run PHP 8.2 on CI #66

merged 6 commits into from
Aug 25, 2023

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Aug 25, 2023

No description provided.

@ruudk
Copy link
Contributor Author

ruudk commented Aug 25, 2023

@simPod This is green now. Would be great if this could be merged.

I cannot use PHPUnit 10 because that requires PHP 8.1 minimum.

So I would also suggest to just merge #62

@simPod
Copy link
Contributor

simPod commented Aug 25, 2023

Unfortunately, I'm not a maintainer. @mcg-web

@mcg-web
Copy link
Member

mcg-web commented Aug 25, 2023

Thank for this PR @ruudk! Can you resolve conflict please?

@ruudk
Copy link
Contributor Author

ruudk commented Aug 25, 2023

Before you tag a new release, after this PR is merged, I'd also like to create a new PR to drop PHP 8.0 (replacing of #62)

@ruudk
Copy link
Contributor Author

ruudk commented Aug 25, 2023

@mcg-web green now.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ab4fd58). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   59.14%           
=========================================
  Files             ?        7           
  Lines             ?      350           
  Branches          ?        0           
=========================================
  Hits              ?      207           
  Misses            ?      143           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mcg-web mcg-web merged commit 6d3a5a1 into overblog:master Aug 25, 2023
8 checks passed
@ruudk ruudk deleted the php82 branch August 25, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants