fix(bridge/qb): "attempt to compare number with boolean" error fix #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to assume this happens when checking for an item that does not exist? Your fix isn't really appropriate though. |
|
it would fix this error because GetItemCount always returns number instead of boolean so there is no possibility for this error to happen again |
You didn't answer my question, and you can just do "or 0" so that you don't end up comparing false to a number.
However I didn't realise this was on the client so the item count is already stored. On server this would be an issue due to iterating the entire inventory for each item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of issue 1582