New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package): support icon urls in radial menu #487
Conversation
What you are proposing are images though, they aren't icons, they don't scale like SVGs and they tend to be blurry. Also the ability to change the height and width is just a disaster waiting to happen with someone releasing a resource using the radial menu. |
In my use case, I generate the radial items dynamically based on the response of an http query. This query includes an image link that is used as an icon. It is not vectorial, but unless very much upscaled it is not blurry. From what I tested I didn't have any blurry results. The ability to change the height and width is here because the image size and offset might differ in different cases and that allow to fix this. The test image I provided in the PR looks good with a width/height of 35, whereas the images I use in my project looks better with 75. |
Also, this feature is implemented in the context menu, I reused the code to test the icon parameter from there. The only difference is that you can't change the size there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine? Might be good to limit size though.
Need type changes for ts package and luadocs.
Thanks for the feedback. Sorry about the types, I don't use TS so I forgot the interface, and I'm not familiar with LUA, I didn't see the doc. Did I miss anything else ? |
Up, |
I like the radial menu.
I use it in one of my projects, and it lack the option to use non FA icons.
This PR is an example implementation to add support for this.
I added width and height parameters to adapt to the images.
I also fixed the type in debug/radial.ts.
Documentation update can be found here : #overextended/overextended.github.io#169