fix: syntax error in plugin.py template #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
approved these changes
Dec 7, 2022
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 7, 2022
* Replace COMMANDS_INIT (which is deprecated in Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 9, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 9, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). Closes overhangio#12. * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 9, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). Closes overhangio#12. * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 9, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). Closes overhangio#12. * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
to kdmccormick/cookiecutter-tutor-plugin
that referenced
this pull request
Dec 9, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). Closes overhangio#12. * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes overhangio#15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: overhangio#16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of overhangio#7.
kdmccormick
added a commit
that referenced
this pull request
Dec 16, 2022
* Confirm that cookiecutter generates a plugin that is compatible with the Tutor v15 (and Open edX Olive). Closes #12. * Replace COMMANDS_INIT (which is deprecated in v15/Olive) with equivalent usage of CLI_DO_INIT_TASKS (which is new in v15/Olive). Closes #15. * Add boilerplate & explanation for CLI_DO_COMMANDS (new in v15/Olive), include a dummy example `tutor local do say-hi` job. * Add boilerplate and explanation for CLI_COMMANDS, including a dummy example `tutor myplugin print-repo` command. * Un-comment as much of the image management block as possible in order to help avoid instances of syntactically invalid commented-out code such as: #16 * Add Makefile to both cookiecutter root as well as generated plugin, providing make rules `test`, `test-format`, `test-lint`, and `test-types`. They are not yet run in CI. Part of #7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.