BUILD Removed IMAGES_BUILD_PLATFORM Key from the Gitlab CI File #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
In your commit title, please explain why you are making this change, as opposed to what the commit is doing.
In this particular PR, why are we making this change? Because we want to publish arm64 images on Docker Hub.
What are we doing? Removing the line from the CI configuration file, such that the CI script picks the default value, which is a cross-platform build.
The why is understandable by anyone without further context, while what needs some expertise to figure out what is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here