Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutor-forum upgrade to Ruby 3.3 #33

Open
kdmccormick opened this issue Mar 19, 2024 · 7 comments
Open

tutor-forum upgrade to Ruby 3.3 #33

kdmccormick opened this issue Mar 19, 2024 · 7 comments
Assignees

Comments

@kdmccormick
Copy link
Contributor

From https://discuss.openedx.org/t/tutor-cs-comment-service-mongo-and-ruby-upgrade/12472 :

We just tested and landed this change 3 which has confirmed that the latest version of cs_comment_service will work with Ruby 3.3 and Mongo 7.
I don’t know what is involved but the relevant tutor code and images should be updated.
If this is using the same Mongo instance as the LMS/CMS, then maybe hold off on the mongo upgrade there until chore: add mongo 7 to testing matrix by DanielVZ96 · Pull Request #34213 · openedx/edx-platform · GitHub 1 merges which will hopefully be soon!

@kdmccormick
Copy link
Contributor Author

@ghassanmas , will you be able to apply and test the Ruby 3.3 upgrade?

@ghassanmas
Copy link
Member

@kdmccormick yes will do, hopefuly in frinday by the end of this week.

@ghassanmas
Copy link
Member

ghassanmas commented Mar 25, 2024

@kdmccormick looking now again at it, I can start with Ruby 3.3, but it would use old mongo verison, given tutor nightly still not updated to mongo 7, so if I understnad correcly I shall wait until tutor nightly is using mongo 7 (overhangio/tutor#1020 ) ? is that correct?. Otherwise I would be testing Ruby 3.3 with Mongo 4.4.25 https://github.com/overhangio/tutor/blob/nightly/tutor/templates/config/defaults.yml#L23

@kdmccormick
Copy link
Contributor Author

Good point @ghassanmas , it would fair for you to wait until Tutor upgrades to Mongo 7 first.

@DawoudSheraz
Copy link

@ghassanmas Hi, the mongo PR has been merged to nightly. You are all set for this. Thanks

@ghassanmas
Copy link
Member

@DawoudSheraz thanks for the update, I think I'll persume/start next Thursday or Friday, hopefully PR will be ready to review by the end of this week, given Redwood cut branch is soon.

@ghassanmas
Copy link
Member

I am not sure which Gemfile or Gemfile.lock, it's suppsoe to be used for 3.3.
Earlier we had Gemfile and Gemfile3 where the former for Ruby 2.* and the latter for ruby 3.*.

However now I can see Gemfile is pinned for ruby 3.1, while Gemfile3 for 3.0. So I though given 3.3. is cloaser to 3.1, Gemfile is suppose to be used, but it didn't work because it's missing a library, thus I openedx a PR upstream to add it

ghassanmas added a commit that referenced this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants