feat: upgrade to Palm #120
Conversation
regisb
force-pushed
the
palm
branch
2 times, most recently
from
f3815e9
to
9e9f94d
Compare
regisb
force-pushed
the
palm
branch
2 times, most recently
from
fadd940
to
9cdd6ef
Compare
| FROM {{ app["name"] }}-common AS {{ app["name"] }}-prod | ||
| {%- for app_name, app in iter_mfes() %} | ||
| ######## {{ app_name }} (production) | ||
| FROM {{ app_name }}-common AS {{ app_name }}-prod | ||
| ENV NODE_ENV=production |
There was a problem hiding this comment.
Cna you we add here support the new feuture
ARG USE_PURGECSS=false
ENV USE_PURGECESS=$USE_PURGECSS
So that it can set at build, i.e. docker build mfe --build-arg USE_PURGECESS=true
ref: https://github.com/openedx/frontend-build#optimization
There was a problem hiding this comment.
I just tested building the mfe image with USE_PURGECSS=true and now I think I know your pain when you build on macOS and Docker eats all your memory.
I'm reluctant to introduce a build-time argument for such a specific use case. Instead, can I suggest we add a {{ patch("mfe-dockerfile-prod-pre-build") }} statement?
EDIT: PurgeCSS reduced the CSS final size from 81kb to 28kb for the Account MFE. That's a huge relative improvement, but relatively small in absolute value, so I'm not sure it's worth the extra build time and resources -- not by default at least.
There was a problem hiding this comment.
Indeed I don't meant to have it by default, just to have it as env-variable would just it make it easier for people to use, it, an extra cli arg vs creating a plguin file. Secondaly regarding resources extensive #125, which is an issue even without using prugeCSS, https://discuss.openedx.org/t/npm-err-code-err-socket-timeout-when-building-mfe-image/10414. Lastly regarding the diff in file size, I would just add that it's not directly about the file size/request size, as it's about perfoamnce; the time it takes the browser to read compile the file content.
There was a problem hiding this comment.
I really prefer a simple plugin over a new build arg or tutor setting. The new patch would also have the advantage that it could also be used for other purposes.
There was a problem hiding this comment.
+1 for a new patch point.
With this new release, we make use of persistent bind-mounts to make it much easier to work on MFE forks. In addition, adding new MFEs is no longer done with `*_MFE_APP` settings, which was awkward, but with appropriate plugins. Close #111.
The MFE is accessible by instructors in ORA exercises that have explicit staff grading steps. The corresponding waffle flag is installed and enabled by default.
The MFE is usable by instructors to send bulk email to learners in a course. The feature itself (the ability to send bulk email) pre-dates this MFE, and must be enabled as usual for the "Email" tab to become visible in the Instructor Dashboard. The difference is that with this change, the tab will include a link to the MFE by default.
I realised that the hooks were imported in the wrong context when I ran `tutor local do init --limit=ecommerce`. This caused the MFE init script to run.
No description provided.