Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INFO_EMAIL and PASSWORD_RESET_SUPPORT_LINK #141

Merged
merged 1 commit into from Aug 28, 2023

Conversation

misilot
Copy link
Contributor

@misilot misilot commented Aug 9, 2023

These two variables are used to generate links in the standard MFE Auth Site Template for resetting passwords.

Fixes #139

I don't currently have anyway to test with tutor-dev but I did apply this on our test instance running tutor local as a patch.

@regisb
Copy link
Contributor

regisb commented Aug 10, 2023

Right. I mentioned the dev environment because you will almost certainly have to implement the "openedx-lms-development-settings" patch, in addition to the production patch.

@misilot
Copy link
Contributor Author

misilot commented Aug 10, 2023

Thanks @regisb. I am willing to try and get it running.

What would be the most straightforward way to test my branch? I assume I will need to build tutor-mfe, but reading through the README in this repo, and the Tutor docs, I am not seeing if there is a way specify the github repo/branch as the source for the mfe.

Edit: Ohh, I think I should be able to install my version of the plugin locally via pip and build the mfe that way.

@misilot
Copy link
Contributor Author

misilot commented Aug 10, 2023

After changing to my tutor-mfe branch

image

After putting in a test email, the href is also populated (bottom left of image)
image

These changes did not require any additional patch to be applied to use the default CONTACT_EMAIL which is generated during launch.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you please add an entry to the changelog with scriv create?

@misilot
Copy link
Contributor Author

misilot commented Aug 16, 2023

@regisb done

These two variables are used to generate links in the standard MFE Auth
Site Template for resetting passwords.

Fixes overhangio#139
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@regisb regisb merged commit 5a0bd7c into overhangio:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Required MFE-Auth variables are not defined which breaks the UI
2 participants