Fix: MFE_HOST check with the new CONFIG_LOADED action #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Oct 2, 2023
This will make sure that MFE_HOST is a subdomain of LMS_HOST, and if not, it will print a warning to notify the user.
since the CONFIG_LOADED action was introduced in the 16.1.2, this version should not be installed in the older versions.
CodeWithEmad
force-pushed
the
fix/config-loaded-action
branch
from
d8d1de0
to
8fdc5ec
Compare
regisb
requested changes
Oct 2, 2023
Done. |
arbrandes
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of overhangio/tutor#557, we should warn the users if they're not following the apps.LMS_HOST pattern for the MFE_HOST.
This will introduce a new check to see if the MFE_HOST is a subdomain of LMS_HOST or not using the new CONFIG_LOADED action .