Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-build 3rd-party MFEs #169

Merged
merged 1 commit into from Dec 7, 2023
Merged

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Dec 5, 2023

When a 3rd party develops an MFE and bind-mounts it, it is expected that the dev image will be automatically built on dev launch. Also, author should be able to build it with tutor images build mymfe-dev. This was not the case for plugins that were loaded after the "mfe" plugin. For instance: "partners" is loaded after "mfe".

See discussion:
https://discuss.openedx.org/t/issues-developing-a-non-core-mfe-using-tutor/11855

When a 3rd party develops an MFE and bind-mounts it, it is expected that
the dev image will be automatically built on `dev launch`. Also, author
should be able to build it with `tutor images build mymfe-dev`. This was
not the case for plugins that were loaded after the "mfe" plugin. For
instance: "partners" is loaded after "mfe".

See discussion:
https://discuss.openedx.org/t/issues-developing-a-non-core-mfe-using-tutor/11855
Copy link
Collaborator

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@regisb regisb merged commit 73b774e into master Dec 7, 2023
1 check passed
@regisb regisb deleted the regisb/fix-3rd-party-build branch December 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants