New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maple Upgrade #11
Maple Upgrade #11
Conversation
65d232d
to
38aece7
Compare
8ea01af
to
45f3b0e
Compare
Embedded MinIO Browser removed replaced with MinIO Console project - tutor users should be aware that the UI will be different. |
a52cdac
to
4df3f9d
Compare
@@ -1,6 +1,6 @@ | |||
minio: | |||
ports: | |||
- "127.0.0.1:9000:9000" | |||
- "127.0.0.1:9001:9001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 could you amend the README accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above: we might have to expose both the 9000 and the 9001 ports.
4df3f9d
to
16cf60b
Compare
16cf60b
to
7c9b3bd
Compare
{{ MINIO_HOST }}{% if not ENABLE_HTTPS %}:80{% endif %} { | ||
reverse_proxy nginx:80 | ||
{{ MINIO_HOST }}{$default_site_port} { | ||
import proxy "minio:9001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait... What is the difference between the server and the console ports? If I understand correctly, the console port is for accessing the web UI, right? The problem is that other services, such as the LMS/CMS, need to be able to access the server from the https://minio.mylms.com address. So the MINIO_HOST should point to the minio server, and not the console.
What this means is that we might need to expose the MinIO console at a different web host. Something like:
{{ MINIO_CONSOLE_HOST }}{$default_site_port} {
import proxy "minio:9000"
{{ MINIO_CONSOLE_HOST }}{$default_site_port} {
import proxy "minio:9001"
}
Do you understand my point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR and failed to upload media files. I can attempt to make changes to make it work. It probably means running the MinIO console at a different domain name.
@@ -1,7 +1,7 @@ | |||
# MinIO | |||
minio-job: | |||
image: {{ MINIO_MC_DOCKER_IMAGE }} | |||
image: { { MINIO_MC_DOCKER_IMAGE } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space between { {
is causing errors on my machine.
Closed by #12 |
setup.py
, bump the “tutor” version that the plugin depends on.__about__.py
module, bump the version number to the next major releasegit grep -i lilac
.MINIO_ACCESS_KEY
andMINIO_SECRET_KEY
are deprecated. Please useMINIO_ROOT_USER
andMINIO_ROOT_PASSWORD
Tests