WIP 5

lib/readable.js

@@ -89,6 +89,7 @@ function _read(size) {
 }
 
 function readStdout(duplex, size) {
+	// TODO Ensure doesn't read again while awaiting 'readable' event
 	console.log('------------');
 	console.log(`readStdout() called: size ${size}`);
 

lib/writable.js

@@ -111,6 +111,7 @@ function writeStdin(duplex, chunk, cb) {
 	if (keepWriting) return cb(null);
 
 	// Stdin needs to drain - callback only once drained or stdin errors
+	// TODO Move listeners to be global rather than adding and removing
 	function done(err) {
 		stdin.removeListener('drain', done);
 		stdin.removeListener('error', done);

test/all.test.js

@@ -22,33 +22,4 @@ describe('Tests', function() {
 	it.skip('dummy', function() {
 		expect(DuplexChild).to.be.ok;
 	});
-
-	it('check Readable', function(cb) {
-		const {Readable} = require('stream');
-
-		const stream = new Readable();
-
-		let called = false,
-			calledTwice = false;
-		stream._read = function(size) {
-			console.log(`_read() called: ${size} bytes`);
-
-			if (called) {
-				calledTwice = true;
-				return this.push(null);
-			}
-
-			called = true;
-
-			const wantsMore = this.push(Buffer.alloc(1000, 'a'));
-			console.log(`wantsMore: ${wantsMore}`);
-		};
-
-		stream.resume();
-
-		stream.on('end', () => {
-			if (calledTwice) return cb(new Error('_read called again before .push returns false'));
-			cb();
-		});
-	});
 });