Skip to content

Commit

Permalink
Fix: Do not require accept-ranges header
Browse files Browse the repository at this point in the history
Some servers e.g. Google Drive download server do not send `accept-ranges` header, but do support range requests. If server does not support ranges, request will fail on test for well-formed `content-range` header anyway.
  • Loading branch information
overlookmotel committed Sep 14, 2018
1 parent 63ac6e2 commit 5ed689b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,7 @@
* Code comments
* Update `got` dependency
* Update dev dependencies

## Next

* Fix: Do not require `accept-ranges` header
2 changes: 0 additions & 2 deletions lib/transfer.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,6 @@ Transfer.prototype.get = function() {
const {headers} = res;

if (this.position) {
if (headers['accept-ranges'] != 'bytes') throw new errors.TransferError('Server does not support range requests');

if (!headers['content-range']) throw new errors.TransferError('No range header');
const range = headers['content-range'].match(/^bytes (\d+)-\d+\/(\d+)$/);
if (!range) throw new errors.TransferError(`Malformed range header '${headers['content-range']}'`);
Expand Down

0 comments on commit 5ed689b

Please sign in to comment.