Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated health check to new port #41

Closed
wants to merge 1 commit into from
Closed

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 18, 2023

mapped Expected Changes

replaced ecs-task-definition › visit-counter
--- current
+++ planned
@@ -1,26 +1,16 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter:20
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter
-container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80,"hostPort":80,"protocol":"tcp"}],"volumesFrom":[]}]'
+container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:8088 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80}],"volumesFrom":[]}]'
 cpu: "256"
 ephemeral_storage: []
-execution_role_arn: ""
 family: visit-counter
-id: visit-counter
 inference_accelerator: []
-ipc_mode: ""
 memory: "512"
 network_mode: awsvpc
-pid_mode: ""
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 20
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
 terraform_address: module.loom[0].aws_ecs_task_definition.visit_counter
 terraform_name: module.loom[0].aws_ecs_task_definition.visit_counter
 volume: []

Blast Radius

items Items edges Edges
10 9

Open in Overmind

warning Risks

high Incompatible Health Check Port [High]

The health check port is being updated from 80 to 8088, but the ecs-task-definition and elbv2-target-group for visit-counter currently indicates the application is configured with a container port of 80, which suggests the application might not listen on port 8088. This could result in failing health checks leading to task restarts or service downtime.

medium Erroneous Health Status Reporting [Medium]

The change might cause the visit-counter ECS service to report a healthy status even if the main application is down, as long as the new service on port 8088 is up, giving a false sense of operational status and possibly affecting the load balancer's ability to properly distribute traffic.

medium Mismatched Load Balancer and Task Port Configuration [Medium]

The current load balancer elbv2-listener is set up to listen on port 80, but the task's health check will be on port 8088 after the change. This discrepancy could lead to configuration conflicts where the load balancer expects the application to be healthy and running on a different port than the one being monitored for health checks.

@dylanratcliffe dylanratcliffe deleted the update-health-check branch December 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant