Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions PR builds #52

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Conversation

JulianGro
Copy link
Member

@JulianGro JulianGro commented Mar 25, 2022

This PR updates GitHub Actions PR builds and enables them to be deployed for public testing.
It is a continuation of #48 so commits from that PR will appear as new in here until #48 is merged. Rebased on master.

To work around limitations with GitHub Actions, this requires an additional server to be running that uploads the builds to S3 and comments where they can be found. This is the same as what has been done on the Vircadia repo for two years. I still need to button up the server software in terms of documentation (since there is none), but we have a running instance of it.

Closes #38

@JulianGro JulianGro added the needs CR This pull request needs to be code reviewed label Mar 25, 2022
@daleglass daleglass added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Apr 3, 2022
@JulianGro JulianGro merged commit dbc2e0b into overte-org:master Apr 3, 2022
@JulianGro JulianGro deleted the s3_pr_builds branch April 3, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR approved This pull request has been successfully code reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub Actions and reinstate CI deployment
3 participants